Skip to content

Conversation

alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Sep 4, 2025

This commit is an extension of #145944 but applied to stdio specifically. The stdio routines are updated away from WASIp1 APIs to using WASIp2 APIs natively. The end goal is to eventually drop the dependency on WASIp1 APIs in the standard library entirely in favor of exclusively depending on WASIp2.

@rustbot
Copy link
Collaborator

rustbot commented Sep 4, 2025

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 4, 2025
@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

This commit is an extension of previous libstd support but applied to stdio
specifically. The stdio routines are updated away from WASIp1 APIs to using
WASIp2 APIs natively. The end goal is to eventually drop the dependency on
WASIp1 APIs in the standard library entirely in favor of exclusively depending
on WASIp2.
Copy link
Contributor

@juntyr juntyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexcrichton
Copy link
Member Author

@bors: r=juntyr

@bors
Copy link
Collaborator

bors commented Sep 4, 2025

📌 Commit d8ca776 has been approved by juntyr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2025
tgross35 added a commit to tgross35/rust that referenced this pull request Sep 5, 2025
std: Implement WASIp2-specific stdio routines

This commit is an extension of rust-lang#145944 but applied to stdio specifically. The stdio routines are updated away from WASIp1 APIs to using WASIp2 APIs natively. The end goal is to eventually drop the dependency on WASIp1 APIs in the standard library entirely in favor of exclusively depending on WASIp2.
tgross35 added a commit to tgross35/rust that referenced this pull request Sep 5, 2025
std: Implement WASIp2-specific stdio routines

This commit is an extension of rust-lang#145944 but applied to stdio specifically. The stdio routines are updated away from WASIp1 APIs to using WASIp2 APIs natively. The end goal is to eventually drop the dependency on WASIp1 APIs in the standard library entirely in favor of exclusively depending on WASIp2.
tgross35 added a commit to tgross35/rust that referenced this pull request Sep 5, 2025
std: Implement WASIp2-specific stdio routines

This commit is an extension of rust-lang#145944 but applied to stdio specifically. The stdio routines are updated away from WASIp1 APIs to using WASIp2 APIs natively. The end goal is to eventually drop the dependency on WASIp1 APIs in the standard library entirely in favor of exclusively depending on WASIp2.
bors added a commit that referenced this pull request Sep 5, 2025
Rollup of 6 pull requests

Successful merges:

 - #144342 (add exact bitshifts)
 - #145709 (Fix LoongArch C function ABI when passing/returning structs containing floats)
 - #146152 (Unify and deduplicate algebraic float tests)
 - #146186 (Update cc-rs to 1.2.33, and switch rustc_codegen_ssa to use find-msvc-tools)
 - #146207 (std: Implement WASIp2-specific stdio routines)
 - #146217 (fix ICE when suggesting `::new`)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Sep 5, 2025
Rollup of 5 pull requests

Successful merges:

 - #144342 (add exact bitshifts)
 - #145709 (Fix LoongArch C function ABI when passing/returning structs containing floats)
 - #146152 (Unify and deduplicate algebraic float tests)
 - #146207 (std: Implement WASIp2-specific stdio routines)
 - #146217 (fix ICE when suggesting `::new`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7fc547c into rust-lang:master Sep 5, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Sep 5, 2025
rust-timer added a commit that referenced this pull request Sep 5, 2025
Rollup merge of #146207 - alexcrichton:wasip2-stdio, r=juntyr

std: Implement WASIp2-specific stdio routines

This commit is an extension of #145944 but applied to stdio specifically. The stdio routines are updated away from WASIp1 APIs to using WASIp2 APIs natively. The end goal is to eventually drop the dependency on WASIp1 APIs in the standard library entirely in favor of exclusively depending on WASIp2.
tgross35 added a commit to tgross35/rust that referenced this pull request Sep 6, 2025
…tgross35

std: Update `wasi` crate dependency

The recent work on the WASIp2 target being integrated into the standard library (rust-lang#146207, rust-lang#145944) ended up causing a bug in nightly on the target. This [has now been fixed](bytecodealliance/wasi-rs#115) in the `wasi` crate so this commit pulls in the updated version to ensure bindings work correctly.
rust-timer added a commit that referenced this pull request Sep 6, 2025
Rollup merge of #146257 - alexcrichton:update-wasi-crate, r=tgross35

std: Update `wasi` crate dependency

The recent work on the WASIp2 target being integrated into the standard library (#146207, #145944) ended up causing a bug in nightly on the target. This [has now been fixed](bytecodealliance/wasi-rs#115) in the `wasi` crate so this commit pulls in the updated version to ensure bindings work correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants